Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight whole team name column for categories #2938

Merged

Conversation

nickygerritsen
Copy link
Member

No description provided.

@vmcj
Copy link
Member

vmcj commented Mar 2, 2025

How does this look for the default DOMjudge category? I think it will look quite ugly together with the default colors?

@nickygerritsen
Copy link
Member Author

How does this look for the default DOMjudge category? I think it will look quite ugly together with the default colors?

The pink one?
Before:
Screenshot 2025-03-02 at 11 07 36

After:
Screenshot 2025-03-02 at 11 07 54

It's not worse IMHO, since we don't display a flag. If we do, it would be ugly but then just not use that color.

@nickygerritsen nickygerritsen added this pull request to the merge queue Mar 2, 2025
Copy link

github-actions bot commented Mar 2, 2025

Test Results

0 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit f38636a. ± Comparison against base commit d211c1c.

Merged via the queue into DOMjudge:main with commit 4d5a8af Mar 2, 2025
37 checks passed
@nickygerritsen nickygerritsen deleted the category-highlight-fix branch March 2, 2025 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants